Stephen Smalley wrote:
On Wed, 2005-03-30 at 16:27 -0600, Darrel Goeddel wrote:You could also just do: task_lock(current); audit_log_format(ab, " comm=%s", current->comm); task_unlock(current); This avoids an unnecessary copy since we have no use the data after the audit_log_format call.Is this locking truly necessary when accessing current->comm (as opposed to accessing the comm of another task)? Can it be set by any other task? We don't presently hold the lock when accessing it in avc_audit.
I didn't not think so, but I wasn't 100% sure. I only did a quick glance before and thought it best to be safe. Upon further investigation, it sure looks to be fine without holding the task lock.
-- Darrel -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.