[Xen-devel] RE: [PATCH] Rename init_IRQ to xen_init_IRQ

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2006年5月17日 15:02
>On 17 May 2006, at 05:10, Tian, Kevin wrote:
>
>> 	In the start, I moved init_IRQ to x86 io_apic.c which however
>> doesn't
>> work if user compiles xen0/xenU by different configuration file because
>> xenU doesn't compile io_apic by default. I'm not sure whether worthy
>of
>> changing domU config file and then simply keep it within evtchn.c
>
>How about we declare it in evtchn.c always, but attribute((weak))? It's
>small and is marked __init anyway, so no space concern really. And
>it'll avoid putting yet another thing in CONFIG_X86?
>
>  -- Keir

That may work, but I'm not sure whether that style (attribute(weak)) is 
welcomed in kernel world. Previously I just saw such instances in user 
level, like libc. :-)

Especially, irq_ctx_init is also x86 specific and so it seems reasonable 
to put it into CONFIG_X86 and only leave real common stuff there...

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel